This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/862/2/src/rlc.cpp File src/rlc.cpp: Line 108: unsigned num_blocks = rbb->cur_bit > (unsigned)distance() > It is not enough that it is supposed to be positive, What is meant is distance is guaranteed to be positive. since the formula for distance calculation is distance = (vs - va) & window_size with vs = 1,va = 3 and window = 255. i.e (1-3) & 255 = 254 with vs = 3,va = 1 and window = 255. i.e (3-1) & 255 = 2 so with whatever values we put, we cannot get the calculation as negative. Let me know if any other queries -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes