libosmocore[master]: timer: only call the callback if not NULL

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Nov 30 17:34:35 UTC 2016


Patch Set 1:

> I would like to see this being reverted. It doesn't make any sense
 > for the SGSN to start a timer and then don't deal with the timeout.
 > The commit message lacks a traceback of the crash, there is no
 > ticket reference to the issue in the SGSN.
 > 
 > I think we cover up a defect in the SGSN and should be fixing this
 > one instead?

I didn't got a good traceback, because the timer executed at a different time over the main()loop and not with the full stack. I didn't got it real reproducible nor did I took the time to found out more about the real bug. If you like it, revert it. But I still thing it's a good idea to check if timer->cb is set.

Atm. I can produce this bug more likely when trying to use a EC20 with our RBS2000 + co-located pcu, which results in multiple timeouts.

-- 
To view, visit https://gerrit.osmocom.org/1344
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d58d9580708cc0f6d0f4aa17d3e9f2c6235c8e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: No



More information about the gerrit-log mailing list