This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 * Not sure about the debug levels.Multiple lines per subscriber? * With software engineering we learned to put semantic into the function name. Your initial method is called drop pdp context.. but it would crash.. when fixing the crash you changed the semantic as well.. Nothing wrong if you think that changing the semantic is good.. but now the method name is misleading. * IIRC such MS behavior can easily be tested, Jacob wrote quite some SGSN tests, so maybe you test the three cases too? -- To view, visit https://gerrit.osmocom.org/1262 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a41aa2218ec2fda4ea17a37c8cc55cba63dd13 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No