This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (1 comment) * Log message not carrying enough information be helpful when debugging an issue * My previous comment was the missing NULL check but now there is a NULL check but other cases as well. The commit message doesn't explain why you are doing it. The added code doesn't match the name of the method either. https://gerrit.osmocom.org/#/c/1262/2/openbsc/src/gprs/gprs_sgsn.c File openbsc/src/gprs/gprs_sgsn.c: Line 692: LOGP(DGPRS, LOGL_NOTICE, "No mm context for this IMSI\n"); The SGSN might have 1000 or 10000 subscribers. If you add a notice log then make it carry meaningful information... At tleast two cases in this routine. -- To view, visit https://gerrit.osmocom.org/1262 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a41aa2218ec2fda4ea17a37c8cc55cba63dd13 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes