This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: fix error rc in various ASN.1 decoding functions ...................................................................... fix error rc in various ASN.1 decoding functions Fixes: CID#57945, CID#57946, CID#57947, CID#57948, CID#57950, CID#57951 Change-Id: I2d9ee1aa79959c5973041393f4769faa13720898 --- M src/hnbgw_cn.c M src/hnbgw_hnbap.c M src/hnbgw_ranap.c M src/hnbgw_rua.c M src/ranap_common_cn.c 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/hnbgw_cn.c b/src/hnbgw_cn.c index f97f627..0e993e2 100644 --- a/src/hnbgw_cn.c +++ b/src/hnbgw_cn.c @@ -235,7 +235,7 @@ data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return rc; + return -1; } rc = _cn_ranap_rx(cnlink, pdu, data, len); diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c index 59150c9..0473482 100644 --- a/src/hnbgw_hnbap.c +++ b/src/hnbgw_hnbap.c @@ -568,7 +568,7 @@ msg->data, msgb_length(msg), 0, 0); if (dec_ret.code != RC_OK) { LOGP(DHNBAP, LOGL_ERROR, "Error in ASN.1 decode\n"); - return rc; + return -1; } rc = _hnbgw_hnbap_rx(hnb, pdu); diff --git a/src/hnbgw_ranap.c b/src/hnbgw_ranap.c index 7a505a5..7fd6d0a 100644 --- a/src/hnbgw_ranap.c +++ b/src/hnbgw_ranap.c @@ -218,7 +218,7 @@ data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return rc; + return -1; } rc = _hnbgw_ranap_rx(msg->dst, pdu); diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c index ca745b1..2c34421 100644 --- a/src/hnbgw_rua.c +++ b/src/hnbgw_rua.c @@ -537,7 +537,7 @@ msg->data, msgb_length(msg), 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRUA, LOGL_ERROR, "Error in ASN.1 decode\n"); - return rc; + return -1; } rc = _hnbgw_rua_rx(msg, pdu); diff --git a/src/ranap_common_cn.c b/src/ranap_common_cn.c index 3736dce..d02eb37 100644 --- a/src/ranap_common_cn.c +++ b/src/ranap_common_cn.c @@ -296,7 +296,7 @@ data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return rc; + return -1; } message.direction = pdu->present; @@ -525,7 +525,7 @@ data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return rc; + return -1; } message.direction = pdu->present; -- To view, visit https://gerrit.osmocom.org/1304 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d9ee1aa79959c5973041393f4769faa13720898 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder