[MERGED] openbsc[master]: ipaccess-proxy: Check setsockopt() return value

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: ipaccess-proxy: Check setsockopt() return value
......................................................................


ipaccess-proxy: Check setsockopt() return value

Change-Id: I34b082907b6f0b25fe2779f3a1f0a642a9002664
Fixes: Coverity CID 57642
---
M openbsc/src/ipaccess/ipaccess-proxy.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c
index 52e77e8..9e8ec88 100644
--- a/openbsc/src/ipaccess/ipaccess-proxy.c
+++ b/openbsc/src/ipaccess/ipaccess-proxy.c
@@ -1023,7 +1023,13 @@
 		return NULL;
 	}
 
-	setsockopt(bfd->fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	ret = setsockopt(bfd->fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	if (ret < 0) {
+		LOGP(DLINP, LOGL_ERROR, "Could not set socket option\n");
+		close(bfd->fd);
+		talloc_free(ipc);
+		return NULL;
+	}
 
 	ret = connect(bfd->fd, (struct sockaddr *) sa, sizeof(*sa));
 	if (ret < 0) {

-- 
To view, visit https://gerrit.osmocom.org/1314
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34b082907b6f0b25fe2779f3a1f0a642a9002664
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder