[MERGED] libosmocore[master]: osmo-sim-test.c: Fix rmsg check

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-sim-test.c: Fix rmsg check
......................................................................


osmo-sim-test.c: Fix rmsg check

we wanted to check for !rmsg, but used to check for !msg, missing error
returns from read_record_nr().

Change-Id: I79b6a94b1aa947c8329317b0626865c3cd4159c1
Fixes: Coverity CID 57672
---
M utils/osmo-sim-test.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c
index e861748..7b79c58 100644
--- a/utils/osmo-sim-test.c
+++ b/utils/osmo-sim-test.c
@@ -334,7 +334,7 @@
 	case EF_TYPE_RECORD_FIXED:
 		for (i = 0; i < ffdd.num_rec; i++) {
 			rmsg = read_record_nr(chan, i+1, ffdd.rec_len);
-			if (!msg)
+			if (!rmsg)
 				return -EIO;
 			printf("SW: %s\n", osim_print_sw(chan->card, msgb_apdu_sw(msg)));
 			printf("Rec %03u: %s\n", i+1,

-- 
To view, visit https://gerrit.osmocom.org/1299
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79b6a94b1aa947c8329317b0626865c3cd4159c1
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder