[MERGED] libosmocore[master]: osmo_sock_init(): Fix memory leak in error path

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Nov 26 09:48:25 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: osmo_sock_init(): Fix memory leak in error path
......................................................................


osmo_sock_init(): Fix memory leak in error path

We forgot to call freeaddrinfo() in an error path.

Change-Id: Iccbd3beef4c4a70dc443131b909c45e650d8c6a2
Fixes: Coverity CID 135217
---
M src/socket.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/socket.c b/src/socket.c
index 19c513a..cdafadd 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -118,6 +118,7 @@
 					" %s:%u: %s\n",
 					host, port, strerror(errno));
 				close(sfd);
+				freeaddrinfo(result);
 				return -EINVAL;
 			}
 		}

-- 
To view, visit https://gerrit.osmocom.org/1297
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccbd3beef4c4a70dc443131b909c45e650d8c6a2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list