This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/1129/6/openbsc/src/libcommon-cs/common_cs.c File openbsc/src/libcommon-cs/common_cs.c: Line 117: struct msgb *gsm0480_gen_ussdNotify(int level, const char *text) these functions could actually even be part of libosmocore, as they don't reference any gsm_data structures but simply genreate a msgb with something that's specified in gsm 04.80. Line 130: gh = (struct gsm48_hdr *) msgb_push(msg, sizeof(*gh)); pre-pending the L3 heder seems something shared with other functions, at least with gen_releaseComplete below, so a function with argument for msg_type would make sense. -- To view, visit https://gerrit.osmocom.org/1129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a84e3c28576ced91d2ea24103123431f551173 Gerrit-PatchSet: 6 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes