osmo-bts[master]: TRX: prevent segfault upon phy init or cleanup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 24 15:47:35 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

looks good, except for...

https://gerrit.osmocom.org/#/c/1276/1/src/osmo-bts-trx/trx_if.c
File src/osmo-bts-trx/trx_if.c:

Line 621: 		if (tcm) {
this doesn't really make sense. tcm should never be null. If it is, then llist_entry() above has dereferenced an invalid l1h->trx_ctrl_list.next which happens to point at NULL + <offset of 'list' member>.


-- 
To view, visit https://gerrit.osmocom.org/1276
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id979506731ea92401458f1060e87aeb690901539
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list