[MERGED] openbsc[master]: Add support for pdpctx_timer_stop

[pravin]

pravin has submitted this change and it was merged.

Change subject: Add support for pdpctx_timer_stop
......................................................................


Add support for pdpctx_timer_stop

Timer T3395 starts  at the transmission of Deactivate PDP request using
pdpctx_timer_start  but there was no corresponding stop function.
The timer is stopped when Deactivate PDP Context Accept is received.
This according to 3gpp spec reference 24.008 section 6.1.3.4.2.

Change-Id: I825c0a47d39e784dd1b8251f564609262530a5c6
---
M openbsc/src/gprs/gprs_gmm.c
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c
index b30b8d3..1fc2784 100644
--- a/openbsc/src/gprs/gprs_gmm.c
+++ b/openbsc/src/gprs/gprs_gmm.c
@@ -1990,6 +1990,14 @@
 	osmo_timer_schedule(&pdp->timer, seconds, 0);
 }
 
+static void pdpctx_timer_stop(struct sgsn_pdp_ctx *pdp, unsigned int T)
+{
+	if (pdp->T != T)
+		LOGPDPCTXP(LOGL_ERROR, pdp, "Stopping PDP timer %u but "
+			"%u is running\n", T, pdp->T);
+	osmo_timer_del(&pdp->timer);
+}
+
 #if 0
 static void msgb_put_pdp_addr_ipv4(struct msgb *msg, uint32_t ipaddr)
 {
@@ -2464,7 +2472,8 @@
 			mm->imsi, transaction_id);
 		return 0;
 	}
-
+	/* stop timer 3395 */
+	pdpctx_timer_stop(pdp, 3395);
 	return sgsn_delete_pdp_ctx(pdp);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/1261
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I825c0a47d39e784dd1b8251f564609262530a5c6
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>