[PATCH] openbsc[master]: bsc_control.py: style corrections

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Nov 17 16:32:40 UTC 2016


Review at  https://gerrit.osmocom.org/1269

bsc_control.py: style corrections

* replace some tabs indent with spaces
* add comment to make sure no new tabs are used for indentation by emacs
* remove unnecessary parenthesis

Change-Id: Ib79fd4317d40ee4fd87b090b9faf8ebaf4bfca64
---
M openbsc/contrib/bsc_control.py
1 file changed, 22 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/69/1269/1

diff --git a/openbsc/contrib/bsc_control.py b/openbsc/contrib/bsc_control.py
index de0c2a9..ba86947 100755
--- a/openbsc/contrib/bsc_control.py
+++ b/openbsc/contrib/bsc_control.py
@@ -1,4 +1,5 @@
 #!/usr/bin/python
+# -*- mode: python-mode; py-indent-tabs-mode: nil -*-
 
 import sys,os, random
 from optparse import OptionParser
@@ -25,13 +26,13 @@
 	return data[4:plen+3], data[plen+3:]
 
 def connect(host, port):
-	if verbose:
-		print "Connecting to host %s:%i" % (host, port)
+        if verbose:
+                print "Connecting to host %s:%i" % (host, port)
 
-	sck = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-	sck.setblocking(1)
-	sck.connect((host, port))
-	return sck
+        sck = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+        sck.setblocking(1)
+        sck.connect((host, port))
+        return sck
 
 def send(sck, data):
 	if verbose:
@@ -91,24 +92,24 @@
         verbose = options.verbose
 
         if options.cmd_set and options.cmd_get:
-	        parser.error("Get and set options are mutually exclusive!")
+                parser.error("Get and set options are mutually exclusive!")
 
         if not (options.cmd_get or options.cmd_set or options.monitor):
-	        parser.error("One of -m, -g, or -s must be set")
+                parser.error("One of -m, -g, or -s must be set")
 
         if not (options.host):
-	        parser.error("Destination host and port required!")
+                parser.error("Destination host and port required!")
 
         sock = connect(options.host, options.port)
 
         if options.cmd_set:
-	        if len(args) < 2:
-		        parser.error("Set requires var and value arguments")
+                if len(args) < 2:
+                        parser.error("Set requires var and value arguments")
 	        do_set(args[0], ' '.join(args[1:]), options.op_id, sock)
 
         if options.cmd_get:
-	        if len(args) != 1:
-		        parser.error("Get requires the var argument")
+                if len(args) != 1:
+                        parser.error("Get requires the var argument")
 	        do_get(args[0], options.op_id, sock)
 
         data = sock.recv(1024)
@@ -117,14 +118,14 @@
 	        print "Got message:", answer
 
         if options.monitor:
-	        while (True):
-		        data = sock.recv(1024)
-		        if len(data) == 0:
-			        print "Connection is gone."
-			        break
+                while True:
+                        data = sock.recv(1024)
+                        if len(data) == 0:
+                                print "Connection is gone."
+                                break
 
-		        while (len(data)>0):
-			        (answer, data) = remove_ipa_ctrl_header(data)
-			        print "Got message:", answer
+                        while len(data) > 0:
+                                (answer, data) = remove_ipa_ctrl_header(data)
+                                print "Got message:", answer
 
         sock.close()

-- 
To view, visit https://gerrit.osmocom.org/1269
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib79fd4317d40ee4fd87b090b9faf8ebaf4bfca64
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list