This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(2 comments)
minor tweaks, changes generally look good otherwise.
Would also be good not to mix so many changes in a single patch...
You remove the random seed and a cmdline arg, which is not at
all mentioned in the commit log. Using the ipa module is just one
tiny fraction of this patch.
https://gerrit.osmocom.org/#/c/1266/1/openbsc/contrib/bsc_control.py
File openbsc/contrib/bsc_control.py:
Line 11: if None == d:
IMHO yoda conditionals are unusual in py,
and the failure case you want to guard against is illegal anyway:
if d = None:
^
SyntaxError: invalid syntax
Line 73: print "Got message:", a
mixed indenting styles ... we should probably drop all tabs in another commit. But better not add more tabs in this patch either.
--
To view, visit https://gerrit.osmocom.org/1266
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25fd7cd4b42126354b72abd60a3837be5d13e159
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes