[MERGED] openbsc[master]: abisip-find: use protocol constant

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 15 22:35:38 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: abisip-find: use protocol constant
......................................................................


abisip-find: use protocol constant

Use library define instead of directly using hardcoded value.

Change-Id: Ie9b8bc55bf40cf005434f27e205d47ffab959413
---
M openbsc/src/ipaccess/abisip-find.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/ipaccess/abisip-find.c b/openbsc/src/ipaccess/abisip-find.c
index 87c6e50..9fe7df6 100644
--- a/openbsc/src/ipaccess/abisip-find.c
+++ b/openbsc/src/ipaccess/abisip-find.c
@@ -138,8 +138,8 @@
 	if (len < 0)
 		return len;
 
-	/* 2 bytes length, 1 byte protocol (0xfe) */
-	if (buf[2] != 0xfe)
+	/* 2 bytes length, 1 byte protocol */
+	if (buf[2] != IPAC_PROTO_IPACCESS)
 		return 0;
 
 	if (buf[4] != IPAC_MSGT_ID_RESP)

-- 
To view, visit https://gerrit.osmocom.org/1224
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9b8bc55bf40cf005434f27e205d47ffab959413
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list