libosmocore[master]: Add function to get uninterrupted bit run

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pravin gerrit-no-reply at lists.osmocom.org
Mon Nov 14 06:36:22 UTC 2016


Patch Set 6:

(5 comments)

https://gerrit.osmocom.org/#/c/415/6/tests/bitvec/bitvec_test.c
File tests/bitvec/bitvec_test.c:

Line 158: 	OSMO_ASSERT (num == result);
> Have a pre-condition (e.g. state of curbit) and a post condition (curbit)?
Done


Line 256: 	printf ("bitvec_runlength....\n");
> test_array doesn't terminate with a \n maybe you add it here as well?
Done


Line 259: 	bitvec_set_uint(&bv, 0xff, 8);
> yes
Done


Line 261: 	test_bitvec_rl_curbit(&bv, 1, 64, 8);
> and now you read these eight bits.. going through the byte aligned case
Done


Line 262: 	test_bitvec_rl_curbit(&bv,0 , 64, 56);
> ok I will add test case for unaligned case in my next patch set.
Done


-- 
To view, visit https://gerrit.osmocom.org/415
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae153d3639ea6b891c1fc10d7801a435c9492e26
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list