This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/1216/3/src/tbf.cpp File src/tbf.cpp: Line 1035: /* Start Tmr only if it is UL TBF */ Does the entire message exist for DL as well? Maybe move the method to the UL subclass of the tbf? Line 1273: ul_tbf = talloc(tall_pcu_ctx, struct gprs_rlcmac_ul_tbf); eeek can't we just remember somehow else we need to generate reject? https://gerrit.osmocom.org/#/c/1216/3/src/tbf.h File src/tbf.h: Line 267: void handle_tbf_reject(struct gprs_rlcmac_bts *bts, GprsMs *ms, This is not a method of the TBF? Move to a different header file? I know it _creates_ a tbf and sets internal state to be used for the reject scheduling.. -- To view, visit https://gerrit.osmocom.org/1216 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05ff25124b58905586caa0c0c37023d69724f121 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes