libosmocore[master]: utils/conv_gen.py: separate code definitions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Thu Nov 10 18:05:10 UTC 2016


Patch Set 1: Code-Review-1

(2 comments)

If they're going to be split, I'd rather give the file with the code a GSM specific name so that if we end up doing others in there, we can use a different file.

It also opens the option for the future to have the .py with the code included in the subprojects rather than here. (obviously not with this change alone, but it's a step in the right direction)

https://gerrit.osmocom.org/#/c/1223/1/utils/conv_codes.py
File utils/conv_codes.py:

Line 5: poly = lambda *args: sum([(1 << x) for x in args])
This should stay with the common code and be imported along with ConvolutionalCode


Line 31: conv_codes = [
Use a gsm specific name


-- 
To view, visit https://gerrit.osmocom.org/1223
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3428561251b7d7a180d1e9b6fcaad50bdbbc37fa
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list