This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 I am still confused by this patch. IT introduces some "common" functions, which in turn call back into the bts/l1if (without any related prefix), but then the common code is not used by all of the BTS models we use? There should be a clear/clean API between the common and the bts-specific parts. osmo-bts started without one but we are making more and more steps into that direction, whcih is good. If you look at the contents of osmo-bts/oml.h, you will see generic functions that can be used by all BTS models, and thoe functions have a clear namespace prefix of oml_. If you want to crate more shared code or change the interface, please change it for all BTS modesl, not just 3 out of 4. Or, if there is something common to those 3 but not the 4th, then it might be best to create some additional library of utility functions, which is then linked into the 3 backends, but not the 4th. In any case, the actual common part should be only code that is used by (or should be used by, or is shared) by all models. -- To view, visit https://gerrit.osmocom.org/1046 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0d3b19dbfaa16d1734321a07a6eb0355bfd77c9 Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: No