This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pravin gerrit-no-reply at lists.osmocom.orgPatch Set 5: (5 comments) https://gerrit.osmocom.org/#/c/415/3/src/bitvec.c File src/bitvec.c: Line 581: * \param[in] b The boolean, sequence of 1's or 0's to be checked > max_bits is not documented Done Line 582: * \param[in] max_bits Total Number of Uncmopresed bits > This doesn't mention that cur_bit will go up. Done Line 590: int temp_res = 0; > Can't you re-order the code to first read up to a full byte.. and then do t Done Line 592: unsigned readIndex = bv->cur_bit; > select the mask once.. max_bits should not change during the call. Done Line 594: unsigned remaining_bytes = max_bits / 8; > select the bytemask once in the beginning Done -- To view, visit https://gerrit.osmocom.org/415 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae153d3639ea6b891c1fc10d7801a435c9492e26 Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes