[MERGED] openbsc[master]: OM2000: Throw error when MO can not be enabled

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: OM2000: Throw error when MO can not be enabled
......................................................................


OM2000: Throw error when MO can not be enabled

Throw warning message in case the MO state does not change
to enabled after sendeing an Enable-Request message.

Change-Id: Idfde8d6f71526e8acfea51835732515a4bee858e
---
M openbsc/src/libbsc/abis_om2000.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_om2000.c b/openbsc/src/libbsc/abis_om2000.c
index 357e2e5..1ab77b1 100644
--- a/openbsc/src/libbsc/abis_om2000.c
+++ b/openbsc/src/libbsc/abis_om2000.c
@@ -2368,6 +2368,16 @@
 		get_value_string(om2k_msgcode_vals, odm->msg_type),
 		get_value_string(om2k_mostate_vals, mo_state));
 
+	/* Throw error message in case we see an enable rsponse that does
+	 * not yield an enabled mo-state */
+	if (odm->msg_type == OM2K_MSGT_ENABLE_RES
+	    && mo_state != OM2K_MO_S_ENABLED) {
+		LOGP(DNM, LOGL_ERROR,
+		     "Rx MO=%s %s Failed to enable MO State!\n",
+		     om2k_mo_name(&odm->o2h.mo),
+		     get_value_string(om2k_msgcode_vals, odm->msg_type));
+	}
+
 	update_mo_state(bts, &odm->o2h.mo, mo_state);
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/1163
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idfde8d6f71526e8acfea51835732515a4bee858e
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder