[MERGED] openbsc[master]: OM2000: Fix state machien for CF/TRXC on START Result

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Nov 9 15:36:26 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: OM2000: Fix state machien for CF/TRXC on START Result
......................................................................


OM2000: Fix state machien for CF/TRXC on START Result

When receiving the 'Start Result' message, for CF and TRXC MO
we directly transition to performing the Operational Info.  In that
case, we need to return after sending the Operational Info and skip
the usual processing for the default case below.

Change-Id: I99860d198b337ffe461b240bda20dc10e1b5b2cb
---
M openbsc/src/libbsc/abis_om2000.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_om2000.c b/openbsc/src/libbsc/abis_om2000.c
index 58d86c6..aeac876 100644
--- a/openbsc/src/libbsc/abis_om2000.c
+++ b/openbsc/src/libbsc/abis_om2000.c
@@ -1518,7 +1518,7 @@
 		osmo_fsm_inst_state_chg(fi, OM2K_ST_WAIT_OPINFO_ACCEPT,
 				OM2K_TIMEOUT, 0);
 		abis_om2k_tx_op_info(omfp->trx->bts, &omfp->mo->addr, 1);
-		break;
+		return;
 	case OM2K_MO_CLS_DP:
 		/* Transition directoy to WAIT_ENABLE_ACCEPT */
 		osmo_fsm_inst_state_chg(fi, OM2K_ST_WAIT_ENABLE_ACCEPT,

-- 
To view, visit https://gerrit.osmocom.org/1158
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99860d198b337ffe461b240bda20dc10e1b5b2cb
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list