This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/1209/1/src/bts.cpp File src/bts.cpp: Line 1065: if (ul_tbf) { > I would swap the branches and just use if (ul_tbf) {... Done Line 1174: if (ul_tbf) { > same as above Done Line 1267: > what's that and why is it here? If you don't need this code just remove it. Done https://gerrit.osmocom.org/#/c/1209/1/src/encoding.cpp File src/encoding.cpp: Line 703: tbf->current_cs().to_num() - 1, 4); > space at end of line Done -- To view, visit https://gerrit.osmocom.org/1209 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I096a3bb44a65533b9e9b091925dd5f70a8696d61 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes