This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/1183/1/openbsc/src/libbsc/abis_rsl.c File openbsc/src/libbsc/abis_rsl.c: PS1, Line 247: 0x0C) Please use a #defien for that (in libosmocore) Line 249: msgb_tv_put(msg, 0xF2, 0x00); please have a proper #define for this IE (like RSL_IE_ERIC_BCCH_MAPPING) rather than using a magic number. PS1, Line 249: 0x00 #define for ERIC_BCCH_MAP_NORMAL 0x00 and ERIC_BCCH_MAP_EXTD 0x01, also in libosmocore/gsm/protocol/gsm_08_58.h -- To view, visit https://gerrit.osmocom.org/1183 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0900f9b810744172b3090ce1b0ef7b7a1132946 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes