This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/1209/1/src/bts.cpp
File src/bts.cpp:
Line 1065: if(ul_tbf == NULL) {
I would swap the branches and just use if (ul_tbf) {...
Also, note the whitespace between if and (
Line 1174: if(ul_tbf == NULL) {
same as above
Line 1267: #if 0
what's that and why is it here? If you don't need this code just remove it. If you need but it's not working than fix it.
https://gerrit.osmocom.org/#/c/1209/1/src/encoding.cpp
File src/encoding.cpp:
Line 703: bitvec_write_field(dest, wp, 100, 8); // WAIT_INDICATION value
space at end of line
--
To view, visit https://gerrit.osmocom.org/1209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I096a3bb44a65533b9e9b091925dd5f70a8696d61
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes