[PATCH] osmo-bts[master]: dtx_check.gawk: Fix false-positives in DTX check

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1207

to look at the new patch set (#3).

dtx_check.gawk: Fix false-positives in DTX check

Previously, if ONSET happened exactly at the place where next SID FIRST
or UPDATE should be it was incorrectly detected as error. Similarly,
continuos FACCH was misinterpreted as error.

Change-Id: I43fdbceea0dbdb0833c3b1cf0fc3b825803ed30e
---
M contrib/dtx_check.gawk
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/1207/3

diff --git a/contrib/dtx_check.gawk b/contrib/dtx_check.gawk
index 7ac8b6d..3a3fa26 100755
--- a/contrib/dtx_check.gawk
+++ b/contrib/dtx_check.gawk
@@ -40,7 +40,7 @@
 			CHK = "FAIL: " TYPE " followed by " $2 " instead of P2."
 			ERR++
 		}
-		if ("OK" == CHK) { # check inter-SID distances:
+		if ("OK" == CHK && "ONSET" != $2) { # check inter-SID distances:
 			if ("UPDATE" == TYPE) {
 				if (DELTA > U_MAX) {
 					CHK = "FAIL: delta (" $1 - FN "fn) from previous SID UPDATE (@" FN ") too big " DELTA "ms > " U_MAX "ms."
@@ -62,8 +62,8 @@
 				}
 			}
 		}
-		if ("FACCH" == TYPE && "FIRST" != $2 && 1 == SILENCE) { # check FACCH handling
-			CHK = "FAIL: incorrect silence resume after FACCH."
+		if ("FACCH" == TYPE && "FIRST" != $2 && "FACCH" != $2 && 1 == SILENCE) { # check FACCH handling
+			CHK = "FAIL: incorrect silence resume with " $2 " after FACCH."
 			ERR++
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/1207
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43fdbceea0dbdb0833c3b1cf0fc3b825803ed30e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder