[PATCH] osmo-bts[master]: Fix false-positive in DTX check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 7 15:18:14 UTC 2016


Review at  https://gerrit.osmocom.org/1207

Fix false-positive in DTX check

Previously, if ONSET happened exactly at the place where next SID FIRST
or UPDATE should be it was incorrectly detected as error.

Change-Id: I43fdbceea0dbdb0833c3b1cf0fc3b825803ed30e
---
M contrib/dtx_check.gawk
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/1207/1

diff --git a/contrib/dtx_check.gawk b/contrib/dtx_check.gawk
index 7ac8b6d..76e4b3c 100755
--- a/contrib/dtx_check.gawk
+++ b/contrib/dtx_check.gawk
@@ -40,7 +40,7 @@
 			CHK = "FAIL: " TYPE " followed by " $2 " instead of P2."
 			ERR++
 		}
-		if ("OK" == CHK) { # check inter-SID distances:
+		if ("OK" == CHK && "ONSET" != $2) { # check inter-SID distances:
 			if ("UPDATE" == TYPE) {
 				if (DELTA > U_MAX) {
 					CHK = "FAIL: delta (" $1 - FN "fn) from previous SID UPDATE (@" FN ") too big " DELTA "ms > " U_MAX "ms."

-- 
To view, visit https://gerrit.osmocom.org/1207
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43fdbceea0dbdb0833c3b1cf0fc3b825803ed30e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list