[PATCH] libosmo-sccp[master]: Revert "Fix the .pc files so the -l arg matches the installe...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 3 13:03:29 UTC 2016


Review at  https://gerrit.osmocom.org/1200

Revert "Fix the .pc files so the -l arg matches the installed libraries"

This reverts commit ed9e76e46e530faf2560fc875ecbe83faff8d809.

The libraries in src/ do not have 'osmo' in their name, hence
neither in $prefix/lib. This patch caused linking failure.

Reproduce: do not have libosmo-sccp installed in the system
and make sure no older pkg-config pc files are around.
Build all dependencies with an arbitrary --prefix
passed to configure scripts. Point PKG_CONFIG_PATH (and
optionally LD_LIBRARY_PATH) to this prefix. Finally, build
openbsc using the same --prefix: even though libosmo-sccp
has been installed, it complains:

    CCLD     osmo-bsc_nat
  /usr/bin/ld: cannot find -losmo-sccp
  collect2: error: ld returned 1 exit status
  Makefile:447: recipe for target 'osmo-bsc_nat' failed

Change-Id: I1a113604b2f037b897954fe8d370291d3c1e2a0a
---
M libosmo-mtp.pc.in
M libosmo-sccp.pc.in
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/00/1200/1

diff --git a/libosmo-mtp.pc.in b/libosmo-mtp.pc.in
index 5e99dd3..675d0d3 100644
--- a/libosmo-mtp.pc.in
+++ b/libosmo-mtp.pc.in
@@ -6,5 +6,5 @@
 Name: Osmo MTP Lib
 Description: Osmo MTP Lib
 Version: @VERSION@
-Libs: -L${libdir} -losmo-mtp
+Libs: -L${libdir} -lmtp
 Cflags: -I${includedir}/
diff --git a/libosmo-sccp.pc.in b/libosmo-sccp.pc.in
index 9dd18c1..eda8d49 100644
--- a/libosmo-sccp.pc.in
+++ b/libosmo-sccp.pc.in
@@ -6,5 +6,5 @@
 Name: OpenBSC SCCP Lib
 Description: OpenBSC SCCP Lib
 Version: @VERSION@
-Libs: -L${libdir} -losmo-sccp
+Libs: -L${libdir} -lsccp
 Cflags: -I${includedir}/

-- 
To view, visit https://gerrit.osmocom.org/1200
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a113604b2f037b897954fe8d370291d3c1e2a0a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list