libosmo-abis[master]: add basic unixsocket support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Nov 3 12:35:21 UTC 2016


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/1198/1/src/input/unixsocket.c
File src/input/unixsocket.c:

Line 4:  *
please include a copyright statement pointing to sysmocom (as this was developed under contract), and add yourself as an author of the file.  Possibly with 'based on ...' in case you started off a copy of one of the other e1inp drivers (not sure if that's the case).


Line 158: 	const char *sock_path = "/tmp/rsl_oml";
I don't like thi shaving a fixed / global socket path.  This means there can always ever be only one system-wide such socket.  So multiple BTS with a single BSC wouldn't wokr - and also not multiple BSC (each with their distinct set of BTSs).


Line 177: 	ret = osmo_sock_unix_init(SOCK_SEQPACKET, 0, sock_path, OSMO_SOCK_F_CONNECT);
I'm not sure how portable SOCK_SEQPACKET is in case of unix domain sockets.  would it e.g. break FreeBSD builds?


-- 
To view, visit https://gerrit.osmocom.org/1198
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5723b09a5c68a0505829dc732def981e60a907a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list