[PATCH] libosmo-abis[master]: e1_input.h: add missing extern for value string arrays

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 3 12:24:07 UTC 2016


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1191

to look at the new patch set (#2).

e1_input.h: add missing extern for value string arrays

Mark two value string arrays as extern, so symbols aren't created for
each source file that includes the headers.

Tweaked-by: nhofmeyr (commit log)
Signed-off-by: Arran Cudbard-Bell <a.cudbardb at freeradius.org>
Change-Id: Iebf4b3922a48ca2cc20d478aba06224dd89d38cb
---
M include/osmocom/abis/e1_input.h
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/91/1191/2

diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h
index c99b133..4c7f8a0 100644
--- a/include/osmocom/abis/e1_input.h
+++ b/include/osmocom/abis/e1_input.h
@@ -21,7 +21,7 @@
 	E1INP_SIGN_OSMO,	/* IPA CCM OSMO sub-type */
 };
 const char *e1inp_signtype_name(enum e1inp_sign_type tp);
-const struct value_string e1inp_sign_type_names[5];
+extern const struct value_string e1inp_sign_type_names[5];
 
 enum e1inp_ctr {
 	E1I_CTR_HDLC_ABORT,
@@ -68,7 +68,7 @@
 	E1INP_TS_TYPE_HDLC,
 };
 const char *e1inp_tstype_name(enum e1inp_ts_type tp);
-const struct value_string e1inp_ts_type_names[6];
+extern const struct value_string e1inp_ts_type_names[6];
 
 /* A timeslot in the E1 interface */
 struct e1inp_ts {

-- 
To view, visit https://gerrit.osmocom.org/1191
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebf4b3922a48ca2cc20d478aba06224dd89d38cb
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Arran Cudbard-bell <a.cudbardb at freeradius.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list