This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 4:
(3 comments)
some whitespace...
https://gerrit.osmocom.org/#/c/1167/4/src/bts.cpp
File src/bts.cpp:
Line 92: { "immediate.assignment_UL", "Immediate Assign UL "},
the code above uses tabs to indent between comma and description, below code should do the same.
https://gerrit.osmocom.org/#/c/1167/4/src/tbf_dl.cpp
File src/tbf_dl.cpp:
Line 1335:
(we typically have a single blank line to separate)
https://gerrit.osmocom.org/#/c/1167/4/src/tbf_ul.cpp
File src/tbf_ul.cpp:
Line 541:
(could drop this blank line)
--
To view, visit https://gerrit.osmocom.org/1167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I605b0d66eb217decd35cbb8f87abfa577760245a
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: mrinal <mrinal.mishra at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: mrinal <mrinal.mishra at radisys.com>
Gerrit-HasComments: Yes