openbsc[master]: lchan: Release channel in case of late activation ack

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 2 14:44:50 UTC 2016


Patch Set 4:

ok, so the reason why patch set 3 doesn't work is because apparently the lchan type on the broken channel is set to NONE.

The dyn_ts_switchover_complete verifies whether the lchan->type matches the dyn.pchan_want. normally that would be e.g. GSM_LCHAN_TCH_F.

The reason the type is NONE is apparently here: lchan_act_tmr_cb() actually calls lchan_free(). It's kind of untypical to call rsl_rf_chan_release() on a freed lchan, but it works because the channel type info in the IEs is derived from the pchan type, not the lchan->type.

So we can do:

* set the lchan->type back to the matching GSM_LCHAN_* before calling dyn_ts_switchover_complete(), or
* remove the lchan type check from switchover complete, or
* hack the dyn ts state like in patch set 4 to effect a switch back to PDCH (with the limitation that it probably needs a fix still, I'll submit another patch set)

-- 
To view, visit https://gerrit.osmocom.org/713
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63dc0deaf15ba7c21e20b1e0c7b85f0437e183ed
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-HasComments: No



More information about the gerrit-log mailing list