[PATCH] openbsc[master]: log: count_codecs(): drop logging of non-TCH lchan types

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 2 13:35:19 UTC 2016


Review at  https://gerrit.osmocom.org/1184

log: count_codecs(): drop logging of non-TCH lchan types

count_codecs() is called on every chan act ack, also for channels other than
TCH/F and TCH/H. So this logging happens a lot during normal operation but adds
no real information.

Also, RSL would be the wrong logging category for this -- RSL is about the RSL
communications, not whether our internal code tries to count lchan codecs for
the wrong channel types.

Change-Id: Ibdac3bbe48745fe6a1c31d6f87369c9066c0374a
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/84/1184/1

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index f672750..3788644 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -111,9 +111,6 @@
 		default:
 			break;
 		}
-	} else {
-		LOGP(DRSL, LOGL_DEBUG, "count_codecs unknown lchan->type %s on channel %s\n",
-		     gsm_lchant_name(lchan->type), gsm_ts_and_pchan_name(lchan->ts));
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/1184
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdac3bbe48745fe6a1c31d6f87369c9066c0374a
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list