This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgarvind.sirsikar has submitted this change and it was merged. Change subject: Modify return type of gprs_rlc_dl_window::distance to uint16_t ...................................................................... Modify return type of gprs_rlc_dl_window::distance to uint16_t Since there is a "&mod_sns()" present in this function, the outcome is always unsigned. Change-Id: I66f3db4dc27a6cbef146c832bf8b43f1492358a4 --- M src/rlc.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/src/rlc.h b/src/rlc.h index b693418..b2fcd95 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -300,7 +300,7 @@ const uint16_t v_s() const; const uint16_t v_s_mod(int offset) const; const uint16_t v_a() const; - const int16_t distance() const; + const uint16_t distance() const; /* Methods to manage reception */ int resend_needed(); @@ -539,7 +539,7 @@ m_v_a = (m_v_a + moves) & mod_sns(); } -inline const int16_t gprs_rlc_dl_window::distance() const +inline const uint16_t gprs_rlc_dl_window::distance() const { return (m_v_s - m_v_a) & mod_sns(); } -- To view, visit https://gerrit.osmocom.org/1182 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f3db4dc27a6cbef146c832bf8b43f1492358a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>