libosmocore[master]: Update structure in libosmocore for 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Jun 30 19:09:48 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/427/1/include/osmocom/gsm/l1sap.h
File include/osmocom/gsm/l1sap.h:

Line 51: 	GSM_L1_BURST_TYPE_ACCESS_0 = 4,
What is the reason to start with 0x4 right now? Other code also depends on the fact that the struct is zero initialized? Which spec do you want to have the 0x4 map to?

If 0x0 is not a valid value, and we use it right now, could you add a _INVALID  (or _NONE) burst type?


-- 
To view, visit https://gerrit.osmocom.org/427
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f0f2424a3af7599d986044be25ea4fcc0ca477
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list