This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/433/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: Line 72: enum ph_burst_type burst; > I think Haralds preference is not to use enum in protocols. It is correct that i dislike the use of enums in protocols. However, the protocol we speak about is only used on a local unix domain socket between two processes, so we can ignore that concern. The two programs will have to be compiled with the same compiler and the same compilation flags, but that should be standard anyway. So the only reason to avoid the enum is to stay in the same style. I'd like that, but I wouldn't mandate that. -- To view, visit https://gerrit.osmocom.org/433 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f4c501b2d86d77c78de32a84b1804172ffb6f4d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-HasComments: Yes