This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/426/2/openbsc/src/gprs/sgsn_vty.c File openbsc/src/gprs/sgsn_vty.c: Line 216: if (g_cfg->cipher != GPRS_ALGO_GEA0) what happens Line 571: g_cfg->cipher = get_string_value(gprs_cipher_names, argv[0]); so what about the user configuring an algorithm that's not available? Shouldn't we call the gprs_cipher_supported() and refuse any non-supported algorithms? -- To view, visit https://gerrit.osmocom.org/426 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07d65205be1c75d59744426629ed04cf3cd99f79 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes