This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/335/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 1347: /* TODO: Need to support of MCS8 -> MCS6 transistion */ > Can you add to the comment what would be needed for MCS8->MCS6? I will add more comments. Line 1368: ((GprsCodingScheme::Scheme)(GprsCodingScheme::CS4 + > Which constructor is attempted to be picked here? What is the compile error There is no constructor attempted here. Below is the error we receive without C cast. tbf/TbfTest.cpp: In function ‘void establish_and_use_egprs_dl_tbf_for_retx(BTS*, int, int)’: tbf/TbfTest.cpp:1369:18: error: invalid conversion from ‘int’ to ‘GprsCodingScheme::Scheme’ [-fpermissive] ../src/gprs_ms.h:89:7: error: initializing argument 1 of ‘void GprsMs::set_current_cs_dl(GprsCodingScheme::Scheme)’ [-fpermissive] make[1]: *** [TbfTest.o] Error 1 -- To view, visit https://gerrit.osmocom.org/335 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia357acfe30f4dea95e00749916c6818354f93285 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes