osmo-bts[master]: LC15: Introduce DSP alive timer per TRX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Jun 20 12:55:57 UTC 2016


Patch Set 2: Code-Review-1

(9 comments)

https://gerrit.osmocom.org/#/c/243/2/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:

Line 1420: 	struct msgb *msg = sysp_msgb_alloc();
NULL check?


Line 1430: 		if(fl1h->failure_rep_sent)
coding style


Line 1458: 		LOGP(DL1C, LOGL_FATAL, "Failed to send %s primitive\n", get_value_string(lc15bts_sysprim_names, sys_prim->id));
DSP alive handling just stops here?


Line 1497: 	struct msgb *msg = sysp_msgb_alloc();
error handling


Line 1505: 		LOGP(DL1C, LOGL_FATAL, "Failed to send %s primitive\n", get_value_string(lc15bts_sysprim_names, sys_prim->id));
recovery from error and code duplication.


https://gerrit.osmocom.org/#/c/243/2/src/osmo-bts-litecell15/l1_if.h
File src/osmo-bts-litecell15/l1_if.h:

Line 68: 	uint8_t failure_rep_sent; /* Flag to indicate the failure report has already sent to network before stop BTS itself*/
has already been sent?


https://gerrit.osmocom.org/#/c/243/2/src/osmo-bts-litecell15/lc15bts.c
File src/osmo-bts-litecell15/lc15bts.c:

Line 124: 	case Litecell15_PrimId_IsAliveReq:	return L1P_T_REQ;
tabs vs. spaces here. please be consistent


https://gerrit.osmocom.org/#/c/243/2/src/osmo-bts-litecell15/lc15bts_vty.c
File src/osmo-bts-litecell15/lc15bts_vty.c:

Line 453: 	"Set DSP alive timer period in second\n")
all parameters in VTY need to be documented


Line 459: 	if (( period >  60 ) || ( period < 0 )) {
0-60 range is enforced by the VTY code


-- 
To view, visit https://gerrit.osmocom.org/243
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic075063a5b3294b72cc502a01e9616c296797238
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list