This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-2 (4 comments) For the general approach to alarms https://gerrit.osmocom.org/#/c/260/2/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: Line 5: #define PCU_IF_VERSION 0x05 If you change the protocol, you should bump the version number on both sides as well (or propose a scheme of majory/minor.. or compat level). It might not be obvious why the PCU doesn't respond to the measurement request sent to the BTS? https://gerrit.osmocom.org/#/c/260/2/src/common/oml.c File src/common/oml.c: Line 93: /* GSM 12.21 attributes */ Look at the name of this array. 12.21 TLV do not seem to belong here. Line 414: LOGP(DOML, LOGL_INFO, "%s Tx MEASurement RESult RESPonse\n", gsm_abis_mo_name(mo)); Info might be a bit too verbose here? Line 1242: return oml_tx_mm_stop_meas_ack_nack(mo, meas_id, NM_NACK_NOTH_REPORT_EXIST); That is way too verbose -- To view, visit https://gerrit.osmocom.org/260 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic930baa69fc09ad5059627ed3d85cce5474085b0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes