This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/332/1/src/gprs_coding_scheme.cpp File src/gprs_coding_scheme.cpp: Line 26: * In has 3 level indexing. 0th level is ARQ type It instead of In? Line 33: /* TODO: Need to support ARQ type 1 */ There will be more than two dimensions in that array? What is missing? What is the impact? https://gerrit.osmocom.org/#/c/332/1/src/rlc.h File src/rlc.h: Line 130: GprsCodingScheme cs_current_trans; I would prefer to cs and cs_current_trans being private here. * The setter/getter can be inline so we have no performance difference * We find all places that use cs and see if they are updated to use cs_current_trans -- To view, visit https://gerrit.osmocom.org/332 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I734b1024bb32f2daa43af4adf59f4a17f2294afe Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes