osmo-bts[master]: sysmo: add L3 handle to l1prim messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 16 11:21:13 UTC 2016


Patch Set 2:

> (1 comment)

why? to make sure that a hLayer3 is applied?

I have since noticed that some of the messages were already using hLayer3. After the current patch, the prim_init() sets a hLayer3 which is overwritten shortly after that, so the other functionality is not affected by this patch.

Some functions to generate hLayer3 for a timeslot and similar already existed, and also to retrieve a timeslot and similar back from a hLayer3 handle.

And also, the other hLayer3 functions use a "magic" byte (like the most significant byte always set to 0xbb).

So in fact, we should have rejected this patch, and I should follow up with a merger of my hLayer3 to the existing hLayer3 infrastructure.
The priority is low though, since no harm is done.

-- 
To view, visit https://gerrit.osmocom.org/264
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4533c6cbc160318917e7a672ab6f9a848f01d1b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list