[PATCH] osmo-bts[master]: sysmo-bts/oml.c: add ts_connect_as(), absorbing ts_connect()...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 16 02:45:21 UTC 2016


Review at  https://gerrit.osmocom.org/295

sysmo-bts/oml.c: add ts_connect_as(), absorbing ts_connect() guts

For upcoming dyn PDCH switching, I want to be able to set the pchan dynamically
upon ts_connect(). Thus recoin ts_connect(ts) to ts_connect_as(ts, pchan) and
leave ts_connect() as a thin wrapper to leave init code unchanged.

Change-Id: I09cc794cb424e17411e608c65f2b68e2f2544e07
---
M src/osmo-bts-sysmo/oml.c
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/295/1

diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index 60ab7a8..7ce94f1 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -480,7 +480,7 @@
 	}
 }
 
-static int ts_connect(struct gsm_bts_trx_ts *ts)
+static int ts_connect_as(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config pchan)
 {
 	struct msgb *msg = l1p_msgb_alloc();
 	struct femtol1_hdl *fl1h = trx_femtol1_hdl(ts->trx);
@@ -489,11 +489,16 @@
 	cr = prim_init(msgb_l1prim(msg), GsmL1_PrimId_MphConnectReq, fl1h,
 		       l1p_handle_for_ts(ts));
 	cr->u8Tn = ts->nr;
-	cr->logChComb = pchan_to_logChComb[ts->pchan];
+	cr->logChComb = pchan_to_logChComb[pchan];
 	
 	return l1if_gsm_req_compl(fl1h, msg, opstart_compl_cb, NULL);
 }
 
+static int ts_connect(struct gsm_bts_trx_ts *ts)
+{
+	return ts_connect_as(ts, ts->pchan);
+}
+
 GsmL1_Sapi_t lchan_to_GsmL1_Sapi_t(const struct gsm_lchan *lchan)
 {
 	switch (lchan->type) {

-- 
To view, visit https://gerrit.osmocom.org/295
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09cc794cb424e17411e608c65f2b68e2f2544e07
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list