This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/201/3/openbsc/src/libmsc/gsm_subscriber.c
File openbsc/src/libmsc/gsm_subscriber.c:
Line 212: alloc_exten);
sgrp should have a pointer to the network? So we wouldn't need to duplicate the parameters here?
https://gerrit.osmocom.org/#/c/201/3/openbsc/src/libmsc/vty_interface_layer3.c
File openbsc/src/libmsc/vty_interface_layer3.c:
Line 1060: DEFUN(cfg_nitb_subscr_noext, cfg_nitb_subscr_noext_cmd,
So to mix create-on-demand with regexp + no extension we would need a new command? Can you think of something better?
https://gerrit.osmocom.org/#/c/201/3/openbsc/tests/db/db_test.c
File openbsc/tests/db/db_test.c:
Line 192: if (alice_db) {
Drop the if. We had that before, didn't we? Let the test crash... if it doesn't behave as expected.
--
To view, visit https://gerrit.osmocom.org/201
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes