openbsc[master]: Make random MSISDN assignment optional

[Holger Freyther]

Patch Set 2: Code-Review-1

(4 comments)

* Code duplication for alloc is a concern
* And bigger is the question if we want to overload the field and start setting some extra bits? I would prefer not to.

https://gerrit.osmocom.org/#/c/201/2/openbsc/src/libmsc/ctrl_commands.c
File openbsc/src/libmsc/ctrl_commands.c:

Line 22: #include <stdbool.h>
classic debate. I am in favor of including system headers last. this makes sure our header are resolving all its dependencies.


https://gerrit.osmocom.org/#/c/201/2/openbsc/src/libmsc/gsm_04_08.c
File openbsc/src/libmsc/gsm_04_08.c:

Line 533: 	bool alloc = (GSM_SUBSCR_CREAT_W_NO_EXT & net->subscr_creation_mode) ?
alloc what? :)


https://gerrit.osmocom.org/#/c/201/2/openbsc/src/libmsc/vty_interface_layer3.c
File openbsc/src/libmsc/vty_interface_layer3.c:

Line 1063:        gsmnet->subscr_creation_mode |= GSM_SUBSCR_CREAT_W_NO_EXT;
I find it unfortunate that we use this variable for both the state and as a flag. Can you make this mode a new command with a new variable?

1st decide if to allocate a subscriber
2nd check a separate flag.

And maybe change the random extension as well?


https://gerrit.osmocom.org/#/c/201/2/openbsc/tests/db/db_test.c
File openbsc/tests/db/db_test.c:

Line 192: 	if (alice_db) {
nack. We had this before. We need _strong_ post conditions in the test.


-- 
To view, visit https://gerrit.osmocom.org/201
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes