This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Minh-Quang Nguyen gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/254 to look at the new patch set (#2). LC15: common/oml.c : Alarm - Unsupported channel attributes Change-Id: I52fd6f3edb0e7eb88c6ea97454696fa84e322cf9 --- M src/common/oml.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/54/254/2 diff --git a/src/common/oml.c b/src/common/oml.c index cc87ec4..b32231b 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -838,13 +838,24 @@ struct gsm_bts *bts = ts->trx->bts; struct tlv_parsed tp, *tp_merged; int rc; + char log_msg[100]; + struct gsm_failure_evt_rep failure_rep; abis_nm_debugp_foh(DOML, foh); DEBUGPC(DOML, "Rx SET CHAN ATTR\n"); rc = oml_tlv_parse(&tp, foh->data, msgb_l3len(msg) - sizeof(*foh)); - if (rc < 0) + if (rc < 0) { + snprintf(log_msg, 100, "New value for Set Channel Attribute not supported\n"); + LOGP(DOML, LOGL_NOTICE,"%s", log_msg); + failure_rep.event_type = NM_EVT_PROC_FAIL; + failure_rep.event_serverity = NM_SEVER_MAJOR; + failure_rep.cause_type = NM_PCAUSE_T_MANUF; + failure_rep.event_cause = NM_MM_EVT_MAJ_UNSUP_ATTR; + failure_rep.add_text = (char *)&log_msg; + oml_tx_failure_event_rep(&ts->mo, failure_rep); return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT); + } /* 9.4.21 HSN... */ /* 9.4.27 MAIO */ -- To view, visit https://gerrit.osmocom.org/254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I52fd6f3edb0e7eb88c6ea97454696fa84e322cf9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Jenkins Builder