This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Minh-Quang Nguyen gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/257
to look at the new patch set (#2).
LC15: common/oml.c : Alarm - Unknown formatted O&M message type
Change-Id: I6b700c58b3780d401968610965f07b63872b578c
---
M src/common/oml.c
1 file changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/257/2
diff --git a/src/common/oml.c b/src/common/oml.c
index c840f11..a93f5b9 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1054,8 +1054,25 @@
ret = oml_ipa_set_attr(bts, msg);
break;
default:
- LOGP(DOML, LOGL_INFO, "unknown Formatted O&M msg_type 0x%02x\n",
- foh->msg_type);
+ snprintf(log_msg, 100, "unknown Formatted O&M msg_type 0x%02x\n", foh->msg_type);
+ LOGP(DOML, LOGL_INFO,"%s", log_msg);
+
+ failure_rep.event_type = NM_EVT_COMM_FAIL;
+ failure_rep.event_serverity = NM_SEVER_MAJOR;
+ failure_rep.cause_type = NM_PCAUSE_T_MANUF;
+ failure_rep.event_cause = NM_MM_EVT_MAJ_UKWN_MSG;
+ failure_rep.add_text = (char *)&log_msg;
+
+ trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
+ if (trx) {
+ trx->mo.obj_inst.bts_nr = 0;
+ trx->mo.obj_inst.trx_nr = foh->obj_inst.trx_nr;
+ trx->mo.obj_inst.ts_nr = 0xff;
+ oml_tx_failure_event_rep(&trx->mo, failure_rep);
+ } else {
+ oml_tx_failure_event_rep(&bts->mo, failure_rep);
+ }
+
ret = oml_fom_ack_nack(msg, NM_NACK_MSGTYPE_INVAL);
}
--
To view, visit https://gerrit.osmocom.org/257
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b700c58b3780d401968610965f07b63872b578c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Jenkins Builder