[PATCH] libosmo-sccp[master]: clarify fixme comment, x7

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/228

to look at the new patch set (#2).

clarify fixme comment, x7

The fixme is about an actual message sent back, not about the error log.

Change-Id: I6de8fb202c7beb025232e9b97605e9f46778506a
---
M src/sua.c
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/28/228/2

diff --git a/src/sua.c b/src/sua.c
index 6e187d8..89182d2 100644
--- a/src/sua.c
+++ b/src/sua.c
@@ -846,7 +846,7 @@
 	if (!conn) {
 		LOGP(DSUA, LOGL_ERROR, "COAK for unknwon reference %u\n",
 			conn_id);
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 	conn_restart_rx_inact_timer(conn);
@@ -854,7 +854,7 @@
 	if (conn->state != S_CONN_PEND_OUT) {
 		LOGP(DSUA, LOGL_ERROR, "COAK in wrong state %s\n",
 			get_value_string(conn_state_names, conn->state));
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -EINVAL;
 	}
 
@@ -908,7 +908,7 @@
 	if (!conn) {
 		LOGP(DSUA, LOGL_ERROR, "COREF for unknwon reference %u\n",
 			conn_id);
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 	conn_restart_rx_inact_timer(conn);
@@ -961,7 +961,7 @@
 	if (!conn) {
 		LOGP(DSUA, LOGL_ERROR, "RELRE for unknwon reference %u\n",
 			conn_id);
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 
@@ -1011,7 +1011,7 @@
 	if (!conn) {
 		LOGP(DSUA, LOGL_ERROR, "RELCO for unknwon reference %u\n",
 			conn_id);
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 	conn_restart_rx_inact_timer(conn);
@@ -1058,14 +1058,14 @@
 	if (!conn) {
 		LOGP(DSUA, LOGL_ERROR, "DT1 for unknwon reference %u\n",
 			conn_id);
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 
 	if (conn->state != S_ACTIVE) {
 		LOGP(DSUA, LOGL_ERROR, "DT1 in invalid state %s\n",
 			get_value_string(conn_state_names, conn->state));
-		/* FIXME: error message? */
+		/* FIXME: send error reply down the sua link? */
 		return -1;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/228
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6de8fb202c7beb025232e9b97605e9f46778506a
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder