This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/251/1/src/common/bts.c
File src/common/bts.c:
PS1, Line 47: "osmo-bts/oml.h"
please note all other include files are used with <> instead of "", so please follow that practise.
PS1, Line 254: int rc;
: char log_msg[100];
see my other comment in a different patch of your series about introducing a convenience wrapper around oml_tx_failure_event_rep(). It might even make sense to have that as a varargs function so you can pass in the format string and any additional arguments to the function, avoiding the need to have these log_msg[100] buffers all over the code.
--
To view, visit https://gerrit.osmocom.org/251
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adac2c9dd1570feec14b3e66f8b05c4274cf127
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes