osmo-bts[master]: LC15: l1sap.h: fix wrong L1SAP_FN2PTCCHBLOCK calculation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 13 13:42:20 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/234/1//COMMIT_MSG
Commit Message:

Line 7: LC15: l1sap.h: fix wrong L1SAP_FN2PTCCHBLOCK calculation
Can you please add a reference to the relevant specification / chapter where this was derived from? This should preferrably go into a comment next to the #define.

Also, it would be useful to quickly explain in the commit message how this manifests itself as a problem/bug, if any.

Finally, please drop the LC15 from the patch subject if the change is in the generic/common part of osmo-bts. Thanks!


-- 
To view, visit https://gerrit.osmocom.org/234
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8be1c8b9159c94788857c6de5440a418739f1212
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list