This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Minh-Quang Nguyen gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/258
LC15: common/oml.c : Alarm - Unsupported IPA set attributes
Change-Id: I78f2f846132f9996bb4008643f1a666e366d2f85
---
M src/common/oml.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/58/258/1
diff --git a/src/common/oml.c b/src/common/oml.c
index a93f5b9..6b42b16 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1236,13 +1236,26 @@
struct tlv_parsed tp;
void *obj;
int rc;
+ char log_msg[100];
+ struct gsm_failure_evt_rep failure_rep;
abis_nm_debugp_foh(DOML, foh);
DEBUGPC(DOML, "Rx IPA SET ATTR\n");
rc = oml_tlv_parse(&tp, foh->data, msgb_l3len(msg) - sizeof(*foh));
- if (rc < 0)
+ if (rc < 0) {
+ snprintf(log_msg, 100, "New value for IPAC Set Attribute not supported\n");
+ LOGP(DOML, LOGL_NOTICE,"%s", log_msg);
+ failure_rep.event_type = NM_EVT_PROC_FAIL;
+ failure_rep.event_serverity = NM_SEVER_MAJOR;
+ failure_rep.cause_type = NM_PCAUSE_T_MANUF;
+ failure_rep.event_cause = NM_MM_EVT_MAJ_UNSUP_ATTR;
+ failure_rep.add_text = (char *)&log_msg;
+
+ mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst);
+ oml_tx_failure_event_rep(mo, failure_rep);
return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT);
+ }
/* Resolve MO by obj_class/obj_inst */
mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst);
--
To view, visit https://gerrit.osmocom.org/258
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78f2f846132f9996bb4008643f1a666e366d2f85
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>